search

stephenmcd / cartridge

Ecommerce for Mezzanine
http://cartridge.jupo.org
BSD 2-Clause "Simplified" License
709 stars 299 forks source link

Django 2.2 compatibility #346

Closed petedermott closed 2 years ago

petedermott commented 5 years ago

Currently cartridge and mezzanine have some issues with Django 2.2 this PR aims to fix that.

In order to pass tests (and generally work) Mezzanine and filebrowser_safe also need modifications. I have test versions of these available at github.com/fermorltd/mezzanine@2.2-compat and github.com/fermorltd/filebrowser-safe@2.2-compat respectively. (I hope to make PR's for these when I am sure they are completely clean of any bespoke code)

All tests pass but this is my first shot at this so feedback / code review is welcome.

EDIT: Might be worth noting that this will probably break if using a namespace is not 'shop' for the app as URLs that were previously reversed without them (like this) will no longer work.

henri-hulski commented 2 years ago

Most of this issues should be fixed in version 1.0.0b1. If you find unresolved problems please open a new PR.