Fixing the side effects in Django < 1.10

stephenmcd / django-forms-builder

Let users build forms in Django admin

BSD 2-Clause "Simplified" License

691 stars 281 forks source link

Fixing the side effects in Django < 1.10 #231

Closed krushiraj closed 3 years ago

krushiraj commented 6 years ago

As request.user.is_authenticated was no longer a method it was changed to use as boolean. But this has a side effect for Django < 1.10 where it is a method. Hence added 'is_user_authenticated' which works conditionally and fixes the side effect.

krushiraj commented 5 years ago

Are there any plans to merge this or is it a better option to close this?