stephenmcd / django-socketio

WebSockets for Django
BSD 2-Clause "Simplified" License
1.32k stars 244 forks source link

fix socketio import error #78

Closed dxe4 closed 9 years ago

dxe4 commented 9 years ago

i think this changed at some point

from socketio import SocketIOServer
ImportError: cannot import name SocketIOServer
dxe4 commented 9 years ago

it looks like the failing tests are because of updated requirements i think pip install . gets django 1.8. i'll try to fix it at some point tomorrow.

stephenmcd commented 9 years ago

Thanks. I'll merge this but you should be aware this library is woefully out of date.

Issue #19 contains a lengthy discussion describing what needs to happen. If you do intend to put any effort into this library, I'd strongly suggest focusing on that rather than anywhere else.

Thanks again!

stephenmcd commented 9 years ago

BTW if you can let me know when you're done with everything you want to look then I can push a new patch release to PyPI.

dxe4 commented 9 years ago

yes this was meant to be the start to get the server running with latest gevent-socketio, i will attempt to get it working but i can't guarantee. At least if the server starts others can contribute. @krishn2014 mentioned he could contribute.

The tests passed locally on this one but because the repo wasn't updated for a while the tests broke anyway, i think if you run the latest master before this on travis will still fail

stephenmcd commented 9 years ago

No problem at all! There's no obligation of course, just wanted to make sure your efforts weren't misdirected :-)

Thanks again.