search

stephenmcd / filebrowser-safe

File manager for Mezzanine
Other
41 stars 104 forks source link

Fix import from deprecated `urlresolvers` module #114

Closed simenheg closed 5 years ago

simenheg commented 6 years ago

Importing from the django.core.urlresolvers module was deprecated in favor of django.urls in Django 1.10, and the former was removed entirely in Django 2.0. Import from django.urls instead.

jerivas commented 6 years ago

Thanks Simen.

Our policy is to only support whatever Django versions are currently supported. Right now that is 1.11, 2.0, and 2.1, so I think you can simplify your PR to get rid of the special cases for 1.10 and lower. https://www.djangoproject.com/download/#supported-versions

simenheg commented 6 years ago

Alright!

If the same goes for Mezzanine, I'll update https://github.com/stephenmcd/mezzanine/pull/1876 as well.

Shouldn't the Travis configurations be updated then, to exclude Djangos lower than 1.11? Otherwise I think this change will cause errors with Django 1.8 and 1.9.

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.0.0-alpha.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.0-rc.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: