search

stephenmcd / filebrowser-safe

File manager for Mezzanine
Other
42 stars 104 forks source link

Preserve ACL when when we 'move' a file on S3. #124

Closed xbuzz closed 5 years ago

xbuzz commented 5 years ago

Description

This fixes an issue in S3BotoStorageMixin where the move method would fail to preserve the existing files ACL policy. This is problematic for S3 buckets that do not default to public-read as objects will default to the buckets ACL policy and not the existing objects policy which is expected for a "move" operation.

Steps to reproduce

  1. Create a bucket that doesn't have public-read as the buckets default policy
  2. Upload a new file
  3. Verify correct permissions (as expected)
  4. Rename the file
  5. Note that the thumbnail is correct, but the image now gets the S3 Access Denied message
stephenmcd commented 5 years ago

Thank you

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.0.0-alpha.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.0-rc.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: