Fix rmtree method of S3BotoStorageMixin

stephenmcd / filebrowser-safe

File manager for Mezzanine

Other

41 stars 104 forks source link

Fix rmtree method of S3BotoStorageMixin #125

Closed RandomJo closed 5 years ago

RandomJo commented 5 years ago

The listdir function returns two values, one for directory names and one for file names. These are lists of strings and thus do not have a delete method. Instead of trying to delete each array, we loop through them to build keys that we can delete.

RandomJo commented 5 years ago

Hey, there. This is my first time making a pull request to an open source library, so let me know if I'm not following the process. I also wanted to note that I think this would be a problem for the other mixins as well, but I don't have a real-world scenario to test a fix for those on so I opted to only submit a fix for the one I'm working with, S3.

stephenmcd commented 5 years ago

Sorry about the delay, you followed the process just fine.

Thanks a lot.