stephenmcd / filebrowser-safe

File manager for Mezzanine
Other
41 stars 104 forks source link

Django 4.0.0 compatibility, fixes #135 #136

Closed tswfi closed 2 years ago

tswfi commented 2 years ago

Add Django 4.0.0 compatibility.

This should make the package Django 4.0.0 compatible.

According to https://github.com/stephenmcd/filebrowser-safe/blob/master/README.rst#contributing this project follows Mezzanine's Contribution Guidelines but this repo does not have AUTHORS file. Not sure if it should be added so I left it out.

tswfi commented 2 years ago

@jerivas sorry to ping you, but I guess you have to approve the workflow to be ran again? I also enabled the Django4 parts of the workflow.

tswfi commented 2 years ago

ok, now the workflow should do its thing. @jerivas One more approval for the workflow please?

tswfi commented 2 years ago

ok, so tests and lint are fine but I have a feeling the release step should not be done in a pr (at least from my pr :)

I'm not sure how the workflow is supposed to work.

Any pointers @jerivas?

jerivas commented 2 years ago

@tswfi you're correct, the release step doesn't apply to this branch. It should just be skipped but I'm not sure why it's failing. We can ignore it for now, I'll just do some manual testing later this week and hopefully get this merged soon. Thanks for your initiative!

jerivas commented 2 years ago

Thanks for the help @tswfi. I tested locally and this is working great.

Unfortunately the release workflow keeps failing and it appears to be an issue with the Action we're using https://github.com/cycjimmy/semantic-release-action/issues/79. I'm working on a fix next.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: