stephenmcd / gedit-ftp-browser

FTP plugin for Gedit
1 stars 0 forks source link

Not working for Windows FTPs #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Connect to a Windows FTP

What is the expected output? What do you see instead?
To list the FTP

What version of the product are you using? On what operating system?
Does this project have a version control?! Linux.

Please provide any additional information below.

@list_files method:
if len(a) < 9: return #skip if the line returned is not friendly
always return when running a windows ftp. To make it work for a windows
host, you have to change

from:
#        if len(a) < 9: return #skip if the line returned is not friendly
#        self._list.append(a)
#        self._list.append(item)
#        if re.compile(r'^d').match(a[0]):
#           
self._browser.browser_model.append([self._browser.foldericon,a[8],'d'])
#        else:
#           
self._browser.browser_model.append([self._browser.fileicon,a[8],'f'])

to:
        if re.compile(r'<DIR>').match(a[2]):

self._browser.browser_model.append([self._browser.foldericon,e,'d'])
        else:
            self._browser.browser_model.append([self._browser.fileicon,e,'f'])

Note that self._list is not necessary in the current release. Also the
FileBrowser is sorting the self._browser.browser_model which is really
annoying and is preventing us for a good display.

Thanks for the great plugin though!

Best Regards,

Fabio Zendhi Nagao (nagaozen)

Original issue reported on code.google.com by nagao...@gmail.com on 5 Dec 2008 at 9:52

GoogleCodeExporter commented 9 years ago
thanks Fabio. will try you patch

Original comment by yin...@gmail.com on 3 Nov 2009 at 12:18

GoogleCodeExporter commented 9 years ago

Original comment by yin...@gmail.com on 3 Nov 2009 at 12:47

GoogleCodeExporter commented 9 years ago
This patch has several problems. It's worth noting that the FTP server being 
referred 
to is IIS - most other FTP servers on Windows conform to the UNIX standard 
listing.

- The patch refers to a variable "e" that doesn't exist and breaks the plugin 
entirely
- While the patch corrects directory listing for IIS FTP servers, it breaks 
handling 
of all other FTP servers

I've since corrected these and commited the changes to the repository

Original comment by stephen.mc on 7 Nov 2009 at 2:29

GoogleCodeExporter commented 9 years ago
so does it work on IIS or not now? cause this is the suck

Original comment by ncored...@gmail.com on 28 Jan 2011 at 12:08

GoogleCodeExporter commented 9 years ago
Running the windows FTP in Unix mode fix it.

Original comment by nagao...@gmail.com on 28 Jan 2011 at 5:35