stephenmcd / grappelli-safe

Admin skin for Mezzanine
Other
25 stars 59 forks source link

Drop unneeded submit_line.html template #75

Closed dsanders11 closed 4 years ago

dsanders11 commented 8 years ago

In the same commit I mentioned in #74 the onclick_attrib template variable was dropped. Once you remove that from the grappelli_safe version the only way it differs from mainline Django is that there's an extra style="overflow: auto;" if a popup, the delete link is moved before save, and each input has a custom class.

The custom classes are never used in the CSS and could be accomplished via CSS selector for the input name if anyone downstream needs that functionality.

The order of delete/save doesn't matter, delete has a "float: left" applied to it so visually it is the same no matter the order.

I don't see any use for the style="overflow: auto;" in my testing it's never needed.

I've tested for visual changes after dropping this template in Chrome, Firefox and Safari and it all looks the same to me.

I'm a fan of dropping unnecessary templates in grappelli_safe as much as possible.