search

stephenmcd / grappelli-safe

Admin skin for Mezzanine
Other
25 stars 59 forks source link

Remove outdated action.js #92

Closed kwasielew closed 6 years ago

kwasielew commented 6 years ago

Since Django 1.9 actions.js has changed, so it is not needed anymore to keep old version of it

stephenmcd commented 6 years ago

I tried this against the development versions of Mezzanine and grappelli_safe and it causes some errors - but more importantly I can't verify it's broken without this change. Can you try the development versions and see if you can recreate the problem? It may have been fixed already.

kwasielew commented 6 years ago

Hey, Thanks for checking it. I was checking it on both newest branches/commits(Mezzanine commit - https://github.com/stephenmcd/mezzanine/commit/bec6595fc960013aaa4d590d842acff6d206f20b) Unfortunately problem still exists

stephenmcd commented 6 years ago

I've tried to verify this again with the latest versions of everything and removing actions from this lib means Django's versions are used which are incompatible with the grappelli interface. The correct fix would be to resolve whatever those issues are before removing actions.js from this library.