search

stephenmcd / mezzanine

CMS framework for Django
http://mezzanine.jupo.org
BSD 2-Clause "Simplified" License
4.76k stars 1.64k forks source link

Bootstrap 4 #1908

Open j209 opened 5 years ago

j209 commented 5 years ago

Hi Any plan for bootstrap 4 support?

Noahsok commented 5 years ago

Hi, well it looks like there have been others updating to BS2. you can read their progress and difficulties here https://groups.google.com/forum/#!searchin/mezzanine-users/bootstrap$204%7Csort:date/mezzanine-users/qgE6EZOJGcs/RwvSu_NEVW0J or look at this merge https://github.com/stephenmcd/mezzanine/pull/777

you can see that you can use whatever you want for your frontend but there are some issues with upgrading in the admin.

headkit commented 5 years ago

The links only cover BS2 and BS3. I tried to use BS4 by simply changing the base.html template. I encountered problems with the header menu in the frontend. Did anyone ever try to implement BS4 successfully? Or does anyone have a list of issues to be solved when loading BS4 instead of BS3?

jerivas commented 5 years ago

Hello!

No work has been performed to migrate from Bootstrap 3 to 4. The upgrade is not straightforward, but the official docs provide a migration guide: https://getbootstrap.com/docs/4.3/migration/#summary

A PR implementing that on Mezzanine would be a welcome addition 😊

headkit commented 5 years ago

Thx for the quick reply. Unfortunately I am building a Cartridge system at the moment, so I could not add my work to a Mezzanine PR without difficulties. Also I am not that deep into Mezzanine at the moment as I just started to play around with it.

I will give it a try byediting the base.html and the dropdown.html templates where I will add BS4, remove BS3 and test some header-nav implementatios. The backend seems to work fine using BS4 on a quick test. Any tips would be appreciated.