stephenmcd / mezzanine

CMS framework for Django
http://mezzanine.jupo.org
BSD 2-Clause "Simplified" License
4.76k stars 1.65k forks source link

template tag 'overextends' no longer works in Django 2.2, as the 'load_template_source' method has been removed #1974

Closed molokov closed 3 years ago

molokov commented 3 years ago

Mezzanine provides the 'overextends' template tag. However, the code for this uses the method 'load_template_source' which was removed in Django 2.0 (See https://docs.djangoproject.com/en/1.11/_modules/django/template/loaders/base/#Loader vs https://docs.djangoproject.com/en/2.2/_modules/django/template/loaders/base/#Loader )

It would be nice if this tag could be fixed for the Django 2.2 version of Mezzanine.

molokov commented 3 years ago

... although now I see this warning, so maybe this isn't important, and we should just remove overextends:

if DJANGO_VERSION >= (1, 9):
    warnings.warn(
        "The `overextends` template tag is deprecated in favour of "
        "Django's built-in `extends` tag, which supports recursive "
        "extension in Django 1.9 and above.",
        DeprecationWarning,
        stacklevel=2,
    )
github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 5.0.0-rc.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: