search

stephenmcd / mezzanine

CMS framework for Django
http://mezzanine.jupo.org
BSD 2-Clause "Simplified" License
4.76k stars 1.65k forks source link

Don't enforce email uniqueness when blank, account for multiple existing dupes #1984

Closed dbischof closed 2 years ago

dbischof commented 3 years ago

Don't enforce email uniqueness when blank (emails can be optional), and account for possibility of multiple dupes (such as when migrating from prior to enforcement of uniqueness). Fix regression in stephenmcd/mezzanine#1868

jerivas commented 2 years ago

Fixed in #2018

dbischof commented 2 years ago

@jerivas, #2018 handles multiple existing dupes but it does not handle not enforcing email uniqueness when blank.

Django allows for blank emails. The code as it stands will not allow you to add/modify a new user with a blank email if one already exists (e.g. when using usernames and not emails for logins).

Blank emails should be exempt from the uniqueness check.

jerivas commented 2 years ago

Thanks for following up, I'll fix that next

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 5.1.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: