search

stephenmcd / mezzanine

CMS framework for Django
http://mezzanine.jupo.org
BSD 2-Clause "Simplified" License
4.76k stars 1.65k forks source link

class*="collapse" matches even collapse-closed, unwanted behavior #1987

Closed dbischof closed 3 years ago

dbischof commented 3 years ago

In:

$('fieldset[class*="collapse"]').each(function() {
    $(this).addClass("collapse-open");
    $(this).removeClass("collapse");
});

$('fieldset[class*="collapse-closed"]') matches <fieldset class="module aligned collapse-closed"/>, which leads it to add the collapse-open class. This in turn means collapse-closed and collapse-open always toggle in tandem rather than flopping between each other as intended.

jerivas commented 3 years ago

I'm unable to reproduce this on the latest master branch. Can you provide your admin class fieldsets?

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 5.0.0-rc.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: