search

stephenmcd / mezzanine

CMS framework for Django
http://mezzanine.jupo.org
BSD 2-Clause "Simplified" License
4.75k stars 1.64k forks source link

Pin bleach to version less than 5 #2031

Closed henri-hulski closed 2 years ago

henri-hulski commented 2 years ago

Bleach 5.0.0 doesn't except the keyword argument 'styles' for clean() anymore. So we get the error clean() got an unexpected keyword argument 'styles'. So I pinned the Bleach version to bleach >= 2, <5. Bleach 5.0.0 also doesn't support Python 3.6 anymore. See https://github.com/mozilla/bleach/blob/main/CHANGES.

henri-hulski commented 2 years ago

I had also to upgrade black to 22.3.0 and rerun it, as the old version was broken in the CI. See psf/black#2964.

henri-hulski commented 2 years ago

@jerivas can you please rerun the last actions job? It seems there was a bug in the CI. Now all running green on my fork. See https://github.com/henri-hulski/mezzanine/actions/runs/2116508858.

jerivas commented 2 years ago

Could we switch to bleach > 5 instead? I would prefer to stay up to date instead of locking ourselves into an old version

henri-hulski commented 2 years ago

Sure we can try. Probably this will be a breaking change. You could also merge this first to make a patch release so we have a working version of Mezzanine 5 and I will prepare the move to bleach 5, which will be a major release - Mezzanine 6.

jerivas commented 2 years ago

Well, I made a huge mess while trying to merge this from my phone (currently on vacation). I'll wait until next week to merge into stable.

Thanks for contributing!

henri-hulski commented 2 years ago

What do you mean? It looks quite ok. Can I use the master branch now for the next PR or do you want to change something?

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 5.1.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: