Open mwmadsen67 opened 1 year ago
Here are some comments on your design docs so far. Feel free to make changes when you can, but keep in mind that the way that you plan your features/schema effects how you'll plan your state and routes, so try to prioritize any changes first.
Feature List:
Il leave some comments on the schema next
Schema:
one additional note: It looks like on pinterest that boards can have an optional description, that may be something youll want to add to your boards table in the schema
Hey Mike, I added the suggested changes. I'll leave an alt text and destination link as optional, but I'm not entirely sure how I would implement those yet. I also made the board_id optional. I believe Pinterest allows for pins to be independent of boards, and can be 'unorganized.'
sounds good stephen š
Oh I should've been more clear about this, but boards and pins can still be counted as their own separate features. I was just giving the advice that when you do start working on it that you would do them at the same time.
Let's update the keys in our sample state to camelCase. š«
Let's update the keys in our sample state to camelCase. š«
updated
check entities.pins[2].title, it's missing a comma.
Frontend Routes:
profile page to š« and ShowPin is missing the closing tick.
Everything else looks great! Good job šÆ
Frontend Routes:
profile page to š« and ShowPin is missing the closing tick.
Everything else looks great! Good job šÆ
Made the changes, thank you
Hi Stephen, here is checklist for going through your docs. I'll go through what you have so far and leave comments underneath.
Wiki Page Home
Feature List
Database Schema
back_ticked
back_ticked
back_ticked
Sample State
```javascript...```
). This will display the state as a code block instead of a giant line of textentities
session
errors
(here or inui
)ui
(if needed)comments
inside ofposts