stephenmk / Jitendex

A free, offline, and openly licensed Japanese-to-English dictionary. Updates weekly!
https://jitendex.org
Creative Commons Attribution Share Alike 4.0 International
273 stars 3 forks source link

Replace Yomitan inline styles with CSS file #104

Open stephenmk opened 2 months ago

stephenmk commented 2 months ago

Yomitan recently added support for external CSS files, so inline styles are no longer necessary. This might greatly reduce the storage space consumed by Jitendex.

See: https://github.com/themoeway/yomitan/pull/1080

stephenmk commented 1 month ago

At least one roadblock: https://github.com/yomidevs/yomitan/issues/1500

Lanwara commented 1 week ago

Hey just wondering, if the inline styles disappear will Anki exports still have the required styles? Because I think it's great that this just works out of the box.

anki_zubS55ZobX

stephenmk commented 1 week ago

if the inline styles disappear will Anki exports still have the required styles?

Correct, Anki exports will continue to work correctly by default. If a Yomitan dictionary stores CSS styles in a separate file rather than writing them inline, then Yomitan will embed the entire contents of the CSS file in each Anki flashcard it creates. (These CSS files usually aren't larger than 10KB in size, so the extra storage space required probably isn't a concern).