stephenmk / Jitendex

A free, offline, and openly licensed Japanese-to-English dictionary. Updates weekly!
https://jitendex.org
Creative Commons Attribution Share Alike 4.0 International
249 stars 2 forks source link

Replace embedded SVG images in the Yomitan version with HTML/CSS #29

Closed stephenmk closed 8 months ago

stephenmk commented 8 months ago

Now that Yomitan has had its first stable release and development activity has taken off, it's possible for new features to be implemented.

As far as Jitendex is concerned, I think my top priority is replacing the embedded SVG files with pure HTML/CSS markup as is done with the Mdict (MDD/MDX) version. For a variety of reasons, SVG images are a clumsy way to implement the tag functionality.

Replacing the SVG files will require quite a few new style attributes to be supported by Yomitan. Here's a provisional list.

The "title" attribute is already implemented for images in Yomitan, but it will need to be allowed for other generic container types as well (div, span) in order for hover-text to work with these tag icons.


Unrelated to the SVG images, I'd also like to add some more text-decoration styles in order to make keywords in example sentences more visible (as in the Mdict version).

New fieldset and legend containers could also be implemented so that supplemental information (example sentences, cross references, usage notes, etc.) could be drawn in a rectangular box with a title. People might prefer the current (more compact) style of the Yomitan version, though.

stephenmk commented 8 months ago

I submitted some code edits to Yomitan to enable these features. The changes have been merged and will presumably be available in the next release of the program.

https://github.com/themoeway/yomitan/pull/450

Once this new version of Yomitan is available, I will publish a new version of Jitendex for Yomitan without the embedded SVG icons.

stephenmk commented 8 months ago

Implemented in version 4.0