stephenmk / Jitendex

A free, offline, and openly licensed Japanese-to-English dictionary. Updates weekly!
https://jitendex.org
Creative Commons Attribution Share Alike 4.0 International
248 stars 2 forks source link

Not white-on-black "可" symbol #46

Closed parfait8566 closed 8 months ago

parfait8566 commented 8 months ago

Old table: image

New table: image

Also, it looks quite a bit weird on Anki. I guess it's harder to make it look right without svg files.

parfait8566 commented 8 months ago

Another thing: wouldn't it better to invert the position of forms and readings in the tables?

stephenmk commented 8 months ago

I thought about using the color variables exposed by Yomitan's stylesheets to change the colors of that symbol when the user switches between light and dark themes. I didn't get around to trying it and I figured it was good enough as it was, but I agree it looked better before.

I just reuploaded a new version of Jitendex 4.0 for Yomitan which updates the colors on that symbol. Apologies to everyone who already downloaded and installed it.

The Yomitan color variables aren't exported to Anki, so you'll have to set the color variables on your Anki cards if you want the inverted effect. Otherwise it will still look like your second screenshot.

.card {
    --text-color: black; 
    --background-color: white;
}
.card.nightMode {
    --text-color: white; 
    --background-color: black;
}

wouldn't it better to invert the position of forms and readings in the tables?

Definitely not. The column width would be much wider and more variable on average. Horizontal space is at a premium in the popup window compared to vertical space.