search

stephenmk / Jitendex

A free, offline, and openly licensed Japanese-to-English dictionary. Updates weekly!
https://jitendex.org
Creative Commons Attribution Share Alike 4.0 International
248 stars 2 forks source link

Circles Are Ovally When the Display Font Is Changed #61

Closed MarvNC closed 4 months ago

MarvNC commented 7 months ago

Original chart: chrome_Yomitan_Search_-_発条_-_Yomitan_Search_2024-01-19_22-27-54 After applying css:

* {
  font-family: 'Noto Sans JP', sans-serif;
}

chrome_Yomitan_Search_-_発条_-_Yomitan_Search_2024-01-19_22-27-33

Of course this is a really minor issue and I have no idea how it could be fixed, just wanted to bring this to your attention if you weren't already aware. Feel free to close if not feasible.

stephenmk commented 7 months ago

just wanted to bring this to your attention if you weren't already aware.

Thanks. Yes, I've already spent some time pulling my hair out over it. I guess since it's the font, I'd need to find some way to draw the circle that doesn't involve the text.

I'll leave this issue open since this really is something I need to fix.

stephenmk commented 7 months ago

https://developer.mozilla.org/en-US/docs/Web/CSS/clip-path

I can replace most of the padding and border-radius style stuff I'm doing with a simple clip-path: circle() style to get the effect that I want. I'll have to submit another tiny patch to yomitan to add support for it.

circle

koiyakiya commented 6 months ago

Is this still being worked on? I know it's a minor thing, but it sometimes really bugs me lol

MarvNC commented 6 months ago

Waiting on the SC changes to be released to Yomitan stable, likely.

stephenmk commented 4 months ago

The patch that I submitted to Yomitan in January (described and linked above) was released in a new stable version on April 14.

Starting with version 4.7, new releases of Jitendex for Yomitan should not have this problem.