search

stephennancekivell / scalatest-json

Scalatest matchers for Json with appropriate equality and descriptive error messages.
Apache License 2.0
36 stars 7 forks source link

Add support for Jsoniter Scala #87

Closed baldram closed 4 years ago

baldram commented 4 years ago

To consider adding another module with support for Jsoniter Scala.

libraryDependencies += "com.stephenn" %% "scalatest-jsoniter-scala" % "0.1.0"
baldram commented 4 years ago

Work in progress here. A draft implementation is already in there.

stephennancekivell commented 4 years ago

Hi @baldram, it looks pretty good to me.

Is there anything more you want to add or anything before opening a PR. Maybe an ignored ExampleSpec to show that the output is like.

Cheers

baldram commented 4 years ago

Hi Stephen, exactly I plan to add this ignored spec with more examples, remove a TODO to handle an empty JSON like "[]", update Readme.md. I will also add one more test to show that "null" related issue of Circe (#9) is not relevant here (this should work already).

I will add this shortly.

Cheers

stephennancekivell commented 4 years ago

Cool. No rush. :)

On Sun, 23 Aug 2020, 11:20 pm Marcin Szałomski, notifications@github.com wrote:

Hi Stephen, exactly I plan to add this ignored spec with more examples, remove a TODO to handle an empty JSON like "[]", update Readme.md. I will also add one more test to show that "null" related issue of Circe (#9 https://github.com/stephennancekivell/scalatest-json/issues/9) is not relevant here (this should work already).

I will add this shortly.

Cheers

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stephennancekivell/scalatest-json/issues/87#issuecomment-678773738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFRPZP3Y3CK73KHOXRFMZTSCEJP7ANCNFSM4QITVR2Q .