stephenou / fruitionsite

Build your website with Notion for free
https://fruitionsite.com
MIT License
1.59k stars 217 forks source link

Database Views Do Not Display #241

Open JustSleightly opened 1 year ago

JustSleightly commented 1 year ago

This issue seemed to occur within the last 12 hours for me, as I had other users reporting to me they could see it fine at that time, and not anymore despite 0 changes to my Notion or fruitionsite script.

Issue:

Any sort of database view regardless of layout (Table, Board, Timeline, Calendar, List, Gallery) does not render at all when viewed through my fruitionsite by other users (tested on Chrome and Opera).

This applies to both original database views and linked database views.

When viewing the public site through my default (name).notion.site, the database views render properly.

They appear fine on my end from my own local browser, but it may be because I'm logged into my own Notion account. I am only able to reproduce the issue myself when browsing with Incognito.

Is anyone else having this issue?

JustSleightly commented 1 year ago

Reproduced on Firefox so it's not chromium-based.

wMarciano commented 1 year ago

Yes, same issue! I had just changed my database setup so I thought I mucked something up... not sure if this is better or worse, though— everything being fine on the _____.notion.site page kind of worries me.

sergiozygmunt commented 1 year ago

I am able to reproduce this on https://dial.directory, my deployment of Fruitionsite on all platforms.

jesenator commented 1 year ago

same issue here! just noticed it. I set up the domain to forward to my original notion page for now until this is resolved Does anyone have the source code of an older version of a Notion page containing a database that we can compare to its current version? I'm guessing Notion changed some formatting of the database in an update and that is messing with the cloudflare code

cn-kali-team commented 1 year ago

https://github.com/cn-kali-team/notion-blog I rewrote the project using Rust

wMarciano commented 1 year ago

https://github.com/cn-kali-team/notion-blog I rewrote the project using Rust

Tested this out, and the site functions... but no databases load. (It's a nice alternative project if you prefer Rust to JS though!)

I think @jesenator is on the right track; probably a 'new' database format under the hood that gets implemented on any change. Would explain why some sites still have visible databases (they haven't been edited in a while).

jesenator commented 1 year ago

@wMarciano That's a good point, that some sites still have visible databases. I found this random one: https://nicolasgrenie.com/about. I'll try to compare the html to mine when I have a chance, see if anything stands out

gregcha commented 1 year ago

I also confirm the issue with no changes made recently on my websites

sergiozygmunt commented 1 year ago

On iOS mobile Safari, an additional error occurs on pages with inline databases citing that the installed iOS app has a problem. I suspect this is related to this issue because it only occurs on pages with databases and has also just started happening. 241

cn-kali-team commented 12 months ago

https://github.com/cn-kali-team/notion-blog I rewrote the project using Rust

Tested this out, and the site functions... but no databases load. (It's a nice alternative project if you prefer Rust to JS though!)

I think @jesenator is on the right track; probably a 'new' database format under the hood that gets implemented on any change. Would explain why some sites still have visible databases (they haven't been edited in a while).

图片

gregcha commented 12 months ago

Would explain why some sites still have visible databases (they haven't been edited in a while).

As reported yesterday I didn't perform any changes on my databases for months (no new data or new configuration) but I'm experiencing the exact same issue.

ShinghoiXu commented 12 months ago

https://github.com/cn-kali-team/notion-blog I rewrote the project using Rust

Tested this out, and the site functions... but no databases load. (It's a nice alternative project if you prefer Rust to JS though!) I think @jesenator is on the right track; probably a 'new' database format under the hood that gets implemented on any change. Would explain why some sites still have visible databases (they haven't been edited in a while).

图片

Though rewriting the project using Rust is a great thing, this doesn't help to solve this issue. I viewed your personal website on multiple devices, the database in table format simply disappeared. Here is the screenshot: screenshot 老哥,很期待完全用Rust重写的版本!但这事儿可能还是因为Notion那边改了一些东西导致加载不出来,目前没想出有什么解决方案。

wMarciano commented 12 months ago

As reported yesterday I didn't perform any changes on my databases for months (no new data or new configuration) but I'm experiencing the exact same issue.

I see. Not sure why it only affects some people then; could just be gradually being rolled out.

From a cursory glance at the console, it looks like affected sites throw Uncaught SyntaxError: Invalid or unexpected token @ 8990-e729638051ac913f.js:1 which then leads to several ChunkLoadErrors about chunk 8990.

After looking at the .js file, you can see it abruptly ends at values:["$<title> with your site title appended.

For reference, the normal version (from username.notion.site) looks like this: image

Any ideas as to why the file would randomly be cut off?

cn-kali-team commented 12 months ago

https://github.com/cn-kali-team/notion-blog I rewrote the project using Rust

Tested this out, and the site functions... but no databases load. (It's a nice alternative project if you prefer Rust to JS though!) I think @jesenator is on the right track; probably a 'new' database format under the hood that gets implemented on any change. Would explain why some sites still have visible databases (they haven't been edited in a while).

图片

Though rewriting the project using Rust is a great thing, this doesn't help to solve this issue. I viewed your personal website on multiple devices, the database in table format simply disappeared. Here is the screenshot: screenshot 老哥,很期待完全用Rust重写的版本!但这事儿可能还是因为Notion那边改了一些东西导致加载不出来,目前没想出有什么解决方案。

https://blog.kali-team.cn 强制刷新再试试 ctrl + F5 try again

thisismikovic commented 12 months ago

@cn-kali-team first of all - thank you for your help, I think you did a great job with the rust rewrite! I didn't code for the past 5 years so excuse my stupid questions:

On topic: Your pull request doesn't fix the problem for me - if I use your code change, my homepage never opens (screenshot attached). image

However, I "fixed" broken databases for me by deleting MetaRewriter class. I know it's not really a solution, but it might help others figure this out and provide a better fix.

It should show database content normally: http://thisismikovic.com

@sergiozygmunt for me, it also solved the iOS error message you mentioned.

LudwigStumpp commented 12 months ago

So something is super suspicious (however might not be related to this issue here):

For some to me unknown reason, all the frutionsite pages here are trying to store a numerous of cookies from other sites when visiting them, although the original long-form url from notion doesn't.

Maybe this is just a coincidence but I never saw that happening before the current issue we are now facing.

For instance, the following list is the cookies I end up with on my site www.mlstarterkit.com image

In comparison, the original page https://ludwigstumpp.notion.site/ML-Starter-Kit-986864bfa035414f9d1a0cd4c67095b3: image

EDIT: Seems like the frutionsite version of the Notion page by default accepts all marketing cookies from Notion: https://www.notion.so/Notion-Cookie-Tables-c38abeb47f8e420a94ade9ac053d90fd

sanbotto commented 12 months ago

If you're getting this error:

Uncaught (in promise) ChunkLoadError: Loading chunk 8990 failed.

Set PAGE_TITLE to '' as a workaround to avoid either HTMLRewriter() or MetaRewriter() from breaking the JS script.

My assumption is that Notion added something that wasn't taken into account when creating the code we're all using from Fruition. That something is related to GitHub and has an attribute with "id": "title" and values: ["$<title>"] that seems to not play along well with one of those rewriters (or both) since, instead of replacing $<title> with the value of PAGE_TITLE, it just adds it right next to it and breaks everything.

Also, if you're bothered by the several requests to exp.YOUR_DOMAIN failing due to CORS [1], you can check my suggested changes on PR #244 for this particular issue.

[1]: IDK what they do, but I thought that my table wasn't loading due to it, so I fixed it before fixing the JS stuff.

cn-kali-team commented 12 months ago

@cn-kali-team first of all - thank you for your help, I think you did a great job with the rust rewrite! I didn't code for the past 5 years so excuse my stupid questions:

* Is it possible to use the rust version strictly from the cloudflare web interface, in an easy way of just maintaining one file like with fruition?

* Would it be possible to use your light/dark theme option with fruition?

On topic: Your pull request doesn't fix the problem for me - if I use your code change, my homepage never opens (screenshot attached). image

However, I "fixed" broken databases for me by deleting MetaRewriter class. I know it's not really a solution, but it might help others figure this out and provide a better fix.

It should show database content normally: http://thisismikovic.com

@sergiozygmunt for me, it also solved the iOS error message you mentioned.

I have revised it again https://github.com/stephenou/fruitionsite/pull/243/files

JustSleightly commented 12 months ago

If you're getting this error:

Uncaught (in promise) ChunkLoadError: Loading chunk 8990 failed.

Set PAGE_TITLE to '' as a workaround to avoid either HTMLRewriter() or MetaRewriter() from breaking the JS script.

My assumption is that Notion added something that wasn't taken into account when creating the code we're all using from Fruition. That something is related to GitHub and has an attribute with "id": "title" and values: ["$<title>"] that seems to not play along well with one of those rewriters (or both) since, instead of replacing $<title> with the value of PAGE_TITLE, it just adds it right next to it and breaks everything.

Also, if you're bothered by the several requests to exp.YOUR_DOMAIN failing due to CORS [1], you can check my suggested changes on PR #244 for this particular issue.

[1]: IDK what they do, but I thought that my table wasn't loading due to it, so I fixed it before fixing the JS stuff.

Removing the PAGE_TITLE as a workaround restored my database views! Not sure if someone will come up with a better way to handle it but good enough for me for now.

ShinghoiXu commented 12 months ago

@cn-kali-team first of all - thank you for your help, I think you did a great job with the rust rewrite! I didn't code for the past 5 years so excuse my stupid questions:

* Is it possible to use the rust version strictly from the cloudflare web interface, in an easy way of just maintaining one file like with fruition?

* Would it be possible to use your light/dark theme option with fruition?

On topic: Your pull request doesn't fix the problem for me - if I use your code change, my homepage never opens (screenshot attached). image However, I "fixed" broken databases for me by deleting MetaRewriter class. I know it's not really a solution, but it might help others figure this out and provide a better fix. It should show database content normally: http://thisismikovic.com @sergiozygmunt for me, it also solved the iOS error message you mentioned.

I have revised it again https://github.com/stephenou/fruitionsite/pull/243/files

Thank you for your PR! It works for me! I even didn't change the "notion.so" to "xxxxxx.notion.site", it works smoothly without any problem in multiple browsers, including Safari (both Mac and iOS), Brave (Chromium), Edge, Firefox.

JustSleightly commented 12 months ago

Switched over to @cn-kali-team's PR https://github.com/stephenou/fruitionsite/pull/243

And not only did it fix this issue without needing to remove the PAGE_TITLE but it also resolves this issue better for me as it doesn't need a window.reload https://github.com/stephenou/fruitionsite/issues/234

wayjake commented 12 months ago

Wow, great little community here. Great discussion. Helped me get my site back online quickly! Thank you all!

vipul354750 commented 12 months ago

Switched over to @cn-kali-team's PR #243

And not only did it fix this issue without needing to remove the PAGE_TITLE but it also resolves this issue better for me as it doesn't need a window.reload #234

hey, i changed the code by following this https://github.com/stephenou/fruitionsite/pull/243/files but still cant see my databases. is there anything else required?

thisismikovic commented 12 months ago

Switched over to @cn-kali-team's PR #243 And not only did it fix this issue without needing to remove the PAGE_TITLE but it also resolves this issue better for me as it doesn't need a window.reload #234

hey, i changed the code by following this https://github.com/stephenou/fruitionsite/pull/243/files but still cant see my databases. is there anything else required?

Try in browser incognito/private mode. If you can see the database content there, then you fixed it and you just need to clear your browser cookies and do a hard reload.

vipul354750 commented 12 months ago

Switched over to @cn-kali-team's PR #243 And not only did it fix this issue without needing to remove the PAGE_TITLE but it also resolves this issue better for me as it doesn't need a window.reload #234

hey, i changed the code by following this https://github.com/stephenou/fruitionsite/pull/243/files but still cant see my databases. is there anything else required?

Try in browser incognito/private mode. If you can see the database content there, then you fixed it and you just need to clear your browser cookies and do a hard reload.

ahh it works in incognito. thanks!!

fujikenji commented 11 months ago

My site is my portfolio and I'm on the job market, so I was a little spooked when none of my past projects were showing in the gallery view. Thanks so much for the fix!

mrtngrsbch commented 11 months ago

Switched over to @cn-kali-team's PR #243 And not only did it fix this issue without needing to remove the PAGE_TITLE but it also resolves this issue better for me as it doesn't need a window.reload #234

hey, i changed the code by following this https://github.com/stephenou/fruitionsite/pull/243/files but still cant see my databases. is there anything else required?

Try in browser incognito/private mode. If you can see the database content there, then you fixed it and you just need to clear your browser cookies and do a hard reload.

it does not work for me. i have also tried with 4 browsers :-(

Vetrov0x commented 11 months ago

Switched over to @cn-kali-team's PR #243 And not only did it fix this issue without needing to remove the PAGE_TITLE but it also resolves this issue better for me as it doesn't need a window.reload #234

hey, i changed the code by following this https://github.com/stephenou/fruitionsite/pull/243/files but still cant see my databases. is there anything else required?

Try in browser incognito/private mode. If you can see the database content there, then you fixed it and you just need to clear your browser cookies and do a hard reload.

it does not work for me. i have also tried with 4 browsers :-(

Same, tried all options above and still missing my grid

JustSleightly commented 11 months ago

Is anyone else noticing their Breadcrumbs (The Page > Sub-Page directory/navigation) both at the top of the page or within the page no longer displaying?

jesenator commented 11 months ago

Is anyone else noticing their Breadcrumbs (The Page > Sub-Page directory/navigation) both at the top of the page or within the page no longer displaying?

Yeah, this seems to be an issue (or a purposeful change) with the underlying Notion pages though.

angadsri commented 11 months ago

Side note: the breadcrumb issue seems desktop-only, mobile still shows the path at the top of the page.

mrtngrsbch commented 11 months ago

Now I am very confused because I can understand what is happening. after days of not being able to see the tables in my domain... it turns out that today I can see them ONLY with a Brave profile. I can't see them with other Brave, Chrome, Firefox or Opera profiles.

This is very curious, I can see it with a Brave profile that has many active plugins + NexDNS but I can NOT see it as anonymous without plugins. Sorry I can't give you much more data, but you can ask me if you need.

image

AdamSzwajcowski commented 11 months ago

Try in browser incognito/private mode. If you can see the database content there, then you fixed it and you just need to clear your browser cookies and do a hard reload.

How to do the hard reload? I deleted cookies from my website and Notion and the problem retains, while in incognito mode everything's fine. I'm using Chrome, I checked on Safari and it looks fine as well.

remgriff commented 11 months ago

Hi! Had the same issue and used the new code from here https://github.com/stephenou/fruitionsite/pull/243/files It works like a charm, thank you very much!

mrtngrsbch commented 11 months ago

Hi! Had the same issue and used the new code from here https://github.com/stephenou/fruitionsite/pull/243/files It works like a charm, thank you very much!

Cool ! Now if I see the tables in Brave/Chrome

Tanks @remgriff !

johnnylinsf commented 11 months ago

Had the same issue -- https://github.com/stephenou/fruitionsite/pull/243/files worked for me as well!

But it doesn't work on Safari on iOS -- any ideas?

josedevian commented 10 months ago

had the same issue, https://github.com/stephenou/fruitionsite/pull/243/files works like a charm. thank you for the fix!

Ph15 commented 10 months ago

Hi! Thanks for the fix! The database load properly, but oddly enough I can't point to any specific URL directly anymore. When I send a link to a page, it loads the homepage automatically (you can see the URL changing). Any clue? @cn-kali-team maybe?

For instance, if I'm sending you the following link: https://philipb.cc/Better-understand-and-work-with-personality-types-50-frameworks-d9dd630d42fb49e3af3aca5a416fe53d?pvs=25, you will be automatically redirected to my homepage.

DudeThatsErin commented 10 months ago

@Ph15 Send the beginning of your code the part with the 'page name': 'pageID'

Ph15 commented 10 months ago

@Ph15 Send the beginning of your code the part with the 'page name': 'pageID'

Do you mean this part?

   }else if (slugs.indexOf(url.pathname.slice(1)) > -1) {
      const pageId = SLUG_TO_PAGE[url.pathname.slice(1)];
      return Response.redirect("https://" + MY_DOMAIN + "/" + pageId, 301);
    } else if (
      pages.indexOf(url.pathname.slice(1)) === -1 &&
      url.pathname.slice(1).match(/[0-9a-f]{32}/)
    )
DudeThatsErin commented 10 months ago

@Ph15 No the part at the top where you put your page names and the stuff from the notion links. Looks something like this:

{
'': '2c84684531584894xd8489651',
'about': '2c84684531584894xd8489651',
'page2': '2c84684531584894xd8489651'
}

Random strings there cause it is an example.

Ph15 commented 10 months ago

Oh, here you go! P.S.: When I use the custom strings the pages load properly!

/* Step 1: enter your domain name like fruitionsite.com */
  const MY_DOMAIN = 'philipb.cc';

  /*
   * Step 2: enter your URL slug to page ID mapping
   * The key on the left is the slug (without the slash)
   * The value on the right is the Notion page ID
   */
  const SLUG_TO_PAGE = {
    '': '81da974703d24b9cad61368a57d933ec',
    'notion': '375c976b575f466a9035148c2633b153',
    'personality': 'd9dd630d42fb49e3af3aca5a416fe53d',
    'participation-consciente': 'd92273eb90754330b435e682e8cfbb70',
    'vision-facilitation': '406ca8a92f3c45dcad96c9894f74838f',
    'outils': '9c275e97d0974b819795949fafe9587e',
    'modules': 'a2b9ffb40d0c4e4bb434ccdbb1962561',
    'principes-achat': 'ced7772aca1c493882156a4d59625d0e',
    'inspirations-vivre-relies': 'e8880a6736594cf2946c30b9656bf14e',
    'restaurants': 'b858442434fd43978373917e64c52181',
    'formations-facilitation': 'f2deb9a9ec7f4a98bebcf613acf5a53a',
    'enneagram': '7265a9f832304147866e3ad39fb328e2',
    'facilitation-graphique': 'c7a16c0ebb8c4a88b2445f809d85f9e6',
  };
DudeThatsErin commented 10 months ago

So, what happens when you go to: https://philipb.cc/personality For me it seems to work: image

So, it seems like everything is working normally for me. As far as the original link you shared, that goes to the home page because it is a notion.so link. You just replaced the username.notion.so part with philipb.cc and the code recognizes that and takes you to your home page.

Ph15 commented 10 months ago

Yes, it works for me too with the custom slug pages (all the ones set in the code)

But if I send you a direct link to the following page for instance (which is nested in a database), it redirects you to the homepage: https://philipb.cc/Peer-Production-License-et-CC-BY-NC-SA-0c29c08491e64e188c9343c708cd37dd. (Notion link is: https://philipb.notion.site/Peer-Production-License-et-CC-BY-NC-SA-0c29c08491e64e188c9343c708cd37dd.)

Same if you open a database item in another tab.

DudeThatsErin commented 10 months ago

That’s because if you want to send those database links you need to add that to the 2nd code you shared to me.

any and all pages you want to share need to go to that link.

Thanks, Erin Skidds On Oct 9, 2023 at 1:55 PM -0500, Phil @.***>, wrote:

Yes, it works for me too with the custom slug pages (all the ones set in the code) But if I send you a direct link to the following page for instance (which is nested in a database), it redirects you to the homepage: https://philipb.cc/Peer-Production-License-et-CC-BY-NC-SA-0c29c08491e64e188c9343c708cd37dd. Same if you open a database item in another tab. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Ph15 commented 10 months ago

Hmm, do you mean I need to create a custom slug for each database item @DudeThatsErin?

If so, I don't understand why…! With the previous code there was no need to create a custom slug, all pages automatically had a direct link (like this one: https://philipb.cc/Peer-Production-License-et-CC-BY-NC-SA-0c29c08491e64e188c9343c708cd37dd).

Is there anything else I should change within the code to keep that feature?

Ph15 commented 9 months ago

Hi! Had the same issue and used the new code from here https://github.com/stephenou/fruitionsite/pull/243/files It works like a charm, thank you very much!

@remgriff @josedevian Do you have any idea why it might still not be working in my case (despite using the same code)?

On philipb.cc (and another Fruition website I run), the databases load properly, but oddly enough I can't point to any specific URL directly anymore. When I send a link to a page, it loads the homepage automatically (you can see the URL changing). For instance, if I'm sending you the following link: https://philipb.cc/Better-understand-and-work-with-personality-types-50-frameworks-d9dd630d42fb49e3af3aca5a416fe53d?pvs=25, you will be automatically redirected to my homepage.

I see that on @cn-kali-team's blog I can copy-paste any database subpage link without any issue. If I send you to https://blog.kali-team.cn/Metasploit-Navicat-fbc1390cf57c40b5b576584c48b8e125, it directs you to the page (and not https://blog.kali-team.cn).

Here is my code if needed: https://github.com/Ph15/danslesbois/

lucasctnh commented 6 months ago

tried a lots of fixes above but none worked for me. Passing a version in the redirect finally did the trick https://github.com/stephenou/fruitionsite/issues/267#issuecomment-1841443240