support JSON wihout a file actually being a .json file

stephenplusplus / google-auto-auth

Making it as easy as possible to authenticate a Google API request

MIT License

34 stars 9 forks source link

support JSON wihout a file actually being a .json file #16

Closed stephenplusplus closed 7 years ago

stephenplusplus commented 7 years ago

Fixes #15

This will:

Return an error if a provided keyFile or keyFilename cannot be found on disk
Check if the contents of the provided keyfile can be parsed as JSON
- if so, assume it is JSON
- if not, assume it is PEM

stephenplusplus commented 7 years ago

@SimenB would you mind taking a look?

stephenplusplus commented 7 years ago

Thanks for the ideas and reviewing! Released as 0.6.1

SimenB commented 7 years ago

@stephenplusplus you've forgotten to push the commit updating package.json and the git tag 😄 https://github.com/stephenplusplus/google-auto-auth/blob/master/package.json#L3

stephenplusplus commented 7 years ago

Woops, done. Added you as a contributor to the repo since you've been such a help lately. No obligations to do anything, but your help is very appreciated and always welcome.