search

stephenplusplus / google-auto-auth

Making it as easy as possible to authenticate a Google API request
MIT License
34 stars 9 forks source link

Deprecate? #39

Open stephenplusplus opened 6 years ago

stephenplusplus commented 6 years ago

@ofrobots @justinbeckwith

Should we kill this thing?

JustinBeckwith commented 6 years ago

Hah, how about we actually try integrating google-auth-library into a few of the dependents first :P . I'd be happy to review those PRs!

stephenplusplus commented 6 years ago

The way our libs work now is something like:

HTTP APIs: The client library requires @google-cloud/common. Common uses google-auto-auth to make requests before making requests.

GAPIC APIs: The client library makes all requests through the generated API, which uses google-auto-auth.

So, I think we do have some control over the rollout, but only between the two choices above. Unless there're any objections, I'll start by swapping out GAA for GAL in @google-cloud/common, send a PR, and use that branch to test locally with Storage.

cc @callmehiphop

nolanmar511 commented 6 years ago

Any idea on timeline for upgrading @google-cloud/common to depend on google-auth-library directly? Or on updating google-auto-auto's dependency on google-auth-library ?

I'm working on https://github.com/GoogleCloudPlatform/cloud-profiler-nodejs, which uses @google-cloud/common and we regularly (once every hour) get authorization errors when credentials expire, and so would like to see the changes made in google-auth-library to refresh the token before it expires make it into @google-cloud/common.

stephenplusplus commented 6 years ago

It would be much faster to get GAL upgraded within this library.

@JustinBeckwith @ofrobots could you review #38?

JustinBeckwith commented 6 years ago

So I think we pretty much have this worked out. I'd be 👍 for deprecating this officially now.