search

stephens999 / ashr

An R package for adaptive shrinkage
GNU General Public License v3.0
79 stars 35 forks source link

Better handling of edge cases for estimate_mixprop #93

Closed willwerscheid closed 5 years ago

willwerscheid commented 5 years ago
  1. Removes columns of all zeros from the likelihood matrix (this poses problems for mixIP and has also caused problems for mixSQP in the past).
  2. Skips optimization when there is only one column remaining (passing a single-column likelihood matrix to mixSQP results in an error).

I've also edited for consistency of style and readability.

willwerscheid commented 5 years ago

Improved version of PR #90 , including some suggestions from @pcarbo . Fixes #89 .