stephenscaff / react-animated-cursor

An animated custom cursor React component.
ISC License
309 stars 30 forks source link

Add `showSystemCursorOnClickable` parameter to show system cursor on clickables #40

Closed Favo02 closed 1 year ago

Favo02 commented 1 year ago

fixes #39

Favo02 commented 1 year ago

Thank you for developing this amazing and super useful package! I'm just trying to be helpful.

I think that if someone wants to show the system cursor he probably wants it always visible (also on clickables elements), this is my use case.

But because the package already implemented a way to show cursor (but only outside of clickables) I thought this was intended behaviour so I added an additional parameter to keep them separate (you never know what people wants).

More customization is better than less customization, so I think it is not a bad idea to keep both parameters as they are both really simple to understand and utilize.

Another way could be to always show the cursor with showSystemCursor = true and add an additional parameter such as hideSystemCursorOnClickable (that should be used only with showSystemCursor = true) to hide the cursor only on clickables. The advantage of this solution is one less parameter for the most obvious use case (always show the cursor), but "harder" to understand and to enforce a correct parameter usage.

In the end I would keep them separate to give the maximum personalization in the easiest way, but the decision is yours. Let me know what is your final decision.

Favo02 commented 1 year ago

@stephenscaff sorry for the tag, any update on this?

stephenscaff commented 1 year ago

Migrated to TS and rolled maintained a single option for clickables and all up page. Thanks for your thoughts though. Appreciate you taking the time to help out.