search

stephenscaff / react-animated-cursor

An animated custom cursor React component.
ISC License
273 stars 28 forks source link

Revert "Allow for different behaviour based on the element hovered" #50

Closed stephenscaff closed 9 months ago

stephenscaff commented 9 months ago

Reverts stephenscaff/react-animated-cursor#45

Have to revert this. Didn't vet as much as I should have (or at all honestly given reviewers).

Here are my issues.

  1. PR introduces TS errors, preventing the build. Did you npm run lint? I got

Argument of type 'Clickable' is not assignable to parameter of type 'SetStateAction..., Type 'string' is not assignable to type 'SetStateAction...

We need to make sure that the clickables prop in CursorCore is provided as an array of clickable selectors, as defined in the AnimatedCursorProps type.

  1. Keep it TS now - Find.js should be find.ts, something like this

  2. Provide demo and docs. Add new cursor example to the Demo. Update readme docs with example setup in the Cursor Types section.