search

stephenslab / dsc

Repo for Dynamic Statistical Comparisons project
https://stephenslab.github.io/dsc-wiki
MIT License
12 stars 12 forks source link

Revise dscquery to address Issue #182, implemented new function dscread #195

Closed pcarbo closed 5 years ago

stephens999 commented 5 years ago

i'm wondering about dscread instead of dscread... as a general convention i like dsc better than without _

pcarbo commented 5 years ago

@stephens999 We already have dscquery and dscreval. If you feel strongly, we could change the names of all the functions to dsc_.

stephens999 commented 5 years ago

well it would be good to be consistent, and i would indeed support this change. (we could continue to include the old functions for backward compatibility)

On Thu, May 16, 2019 at 8:25 AM Peter Carbonetto notifications@github.com wrote:

@stephens999 https://github.com/stephens999 We already have dscquery and dscreval. If you feel strongly, we could change the names of all the functions to dsc_.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stephenslab/dsc/pull/195?email_source=notifications&email_token=AANXRRNR6OEBXV7WJ5FWEITPVVOFRA5CNFSM4HNHTVY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRZSFA#issuecomment-493066516, or mute the thread https://github.com/notifications/unsubscribe-auth/AANXRRPH6UR4SPUY4OKYBSTPVVOFRANCNFSM4HNHTVYQ .

pcarbo commented 5 years ago

@gaow If you are okay with this change, I will incorporate it into the Pull Request.

pcarbo commented 5 years ago

When this pull request is merged, we will be able to close Issue #180 and Issue #182.