Print more complete error messages before DSC terminates

stephenslab / dsc

Repo for Dynamic Statistical Comparisons project

https://stephenslab.github.io/dsc-wiki

MIT License

12 stars 12 forks source link

Print more complete error messages before DSC terminates #200

Closed gaow closed 4 years ago

gaow commented 5 years ago

The following WARNING can be improved:

WARNING: Substep varbvs (id=1eaca6835e85814a, index=1) returns an error. Terminating step after completing 23 submitted substeps.

The message should also tell us where to check the error file and / or how to reproduce it. The only possible challenge is whether we have written to disk the problematic script in question at that point (and if not we need to write it).

pcarbo commented 5 years ago

@gaow An alternative, if it is simpler, is to add to the message instructions on how to tell DSC to stop when an error is encountered in order to quickly obtain the error file.

gaow commented 4 years ago

We will revisit the --keep-going behavior that will also resolve this issue. I think we've had enough discussion on slack what should be done in response to errors so I'll just implement it, document and make a new DSC release.