stephenslab / ebnm

R package to fit Empirical Bayes Normal Means model.
https://stephenslab.github.io/ebnm/
12 stars 9 forks source link

Adjust X axis in CDF plot #114

Open pcarbo opened 9 months ago

pcarbo commented 9 months ago

@willwerscheid One issue I noticed with the plots is that the X axis is not adjusted for scale. For example, this is a plot I created for a normal prior with a large sd:

plot(g,incl_pm = FALSE,incl_cdf = TRUE)
Screen Shot 2023-12-20 at 7 52 56 AM

As you can see it would be helpful if the X axis could be adjusted somehow.

pcarbo commented 9 months ago

Relatedly, I noticed that the Y axis sometimes doesn't start at 0. The Y axis should always be between 0 and 1, I think?

willwerscheid commented 4 months ago

By default the x-axis limits are chosen to span the range of the data. I agree about the y-axis and I also agree that we should have a xlim parameter in plot.ebnm.