stephenslab / ebnm

R package to fit Empirical Bayes Normal Means model.
https://stephenslab.github.io/ebnm/
12 stars 9 forks source link

Rewrite point_normal functions #14

Closed willwerscheid closed 5 years ago

willwerscheid commented 5 years ago

Update optimization functions (typically 3-5x faster now). Add LFSR as possible output. Add ebnm_normal function to interface. Add fix_a parameter so that variance of normal can be fixed independently. Add a bunch of new tests.

willwerscheid commented 5 years ago

Closes #10 . Closes #9 .

codecov-io commented 5 years ago

Codecov Report

Merging #14 into master will increase coverage by 11.4%. The diff coverage is 74.56%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #14      +/-   ##
=========================================
+ Coverage   51.69%   63.1%   +11.4%     
=========================================
  Files          13      14       +1     
  Lines         325     458     +133     
=========================================
+ Hits          168     289     +121     
- Misses        157     169      +12
Impacted Files Coverage Δ
R/summary_results_laplace.R 87.5% <ø> (ø)
R/output.R 100% <100%> (+33.33%) :arrow_up:
R/post_sampler_point_normal.R 100% <100%> (ø) :arrow_up:
R/mle_pn_special_cases.R 50% <50%> (ø)
R/ebnm.R 53.57% <53.57%> (ø)
R/ebnm_point_normal.R 71.69% <59.45%> (-17.59%) :arrow_down:
R/ebnm_point_laplace.R 88% <76.92%> (+88%) :arrow_up:
R/mle_point_normal.R 80.43% <82.22%> (+13.76%) :arrow_up:
R/loglik_point_normal.R 92.3% <85.71%> (+0.64%) :arrow_up:
R/summary_results_point_normal.R 96.77% <96.77%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cf8b78...d431104. Read the comment docs.