search

stephenslab / ebnm

R package to fit Empirical Bayes Normal Means model.
https://stephenslab.github.io/ebnm/
12 stars 9 forks source link

Changes to interface #17

Closed willwerscheid closed 5 years ago

willwerscheid commented 5 years ago

As discussed in #16 . Adds mode and scale parameters and renames other parameters (g -> g_init, fixg -> fix_g). Adds a general wrapper to ashr to prepare for adding other functions suggested in #16 . Minor modifications to return object.

codecov-io commented 5 years ago

Codecov Report

Merging #17 into master will increase coverage by 11.18%. The diff coverage is 91.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
+ Coverage    63.1%   74.28%   +11.18%     
===========================================
  Files          14       18        +4     
  Lines         458      626      +168     
===========================================
+ Hits          289      465      +176     
+ Misses        169      161        -8
Impacted Files Coverage Δ
R/mle_pn_special_cases.R 59.37% <0%> (+9.37%) :arrow_up:
R/summary_results_laplace.R 93.75% <100%> (+6.25%) :arrow_up:
R/ebnm_unimodal.R 100% <100%> (ø)
R/summary_results_point_normal.R 96.77% <100%> (ø) :arrow_up:
R/output.R 100% <100%> (ø) :arrow_up:
R/ebnm_normal_scale_mixture.R 100% <100%> (ø)
R/ebnm_normal.R 100% <100%> (ø)
R/ebnm_point_laplace.R 80.48% <75%> (-7.52%) :arrow_down:
R/ebnm_point_normal.R 90.36% <85.45%> (+18.66%) :arrow_up:
R/ebnm.R 85.71% <90.9%> (+32.14%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3dbfd89...28a83b9. Read the comment docs.

willwerscheid commented 5 years ago

Closing -- see pull request #18 .