stephenslab / ebnm

R package to fit Empirical Bayes Normal Means model.
https://stephenslab.github.io/ebnm/
12 stars 9 forks source link

wOBA is a tibble #99

Closed pcarbo closed 1 year ago

pcarbo commented 1 year ago

I noticed that the wOBA data set is a "tibble":

> data(wOBA)
> class(wOBA)
[1] "baseballr_data" "tbl_df"         "tbl"            "data.table"
[5] "data.frame"

This introduces a dependency on the tibble package, which doesn't seem necessary. Maybe you can make it a (more standard) data frame?

Also, can I suggest making the Team column a factor, and replacing the "---"s with NAs, which is what is conventionally done in R?

willwerscheid commented 1 year ago

yes you are right. in fact it requires the baseballr package. i will run as.data.frame() before saving.

willwerscheid commented 1 year ago

fixed