Open pcarbo opened 1 week ago
Thinking about this a bit more, my suggested enhancements may make extrapolation more complex since the current implementation extrapolates the whole L (F) matrix at once.
Is it principled to extrapolate each additive Poisson regression?
The computations for extrapolation are particularly simple, so I'm not sure if there is much to be gained by parallelizing this code (but I could be wrong).
The issue is that https://github.com/stephenslab/fastTopics/blob/f075a01ccb401d91e9a68302f27d401a0a131822/R/fit_poisson_nmf.R#L694
is also a single-threaded bottleneck for large data sets, and my suggestion to compute the loss function in each subproblem does not work here.
Yes, although this relates to your earlier point about the cost function not being parallelized. If designed carefully I think I can tackle all these at the same time. I'll circle back to this soon.
From @aksarkar: