stephenslab / flashr

R package for Empirical Bayes Factor Analysis.
https://stephenslab.github.io/flashr
BSD 3-Clause "New" or "Revised" License
49 stars 11 forks source link

flash_get_ldf() and flash_get_fitted_values() are not exported. #95

Open dcgerard opened 5 years ago

dcgerard commented 5 years ago

The documentation in flash() says

Use flash_get_ldf to access standardized loadings and factors; use flash_get_fitted_values to access fitted LF'.

But flash_get_ldf() and flash_get_fitted_values() are not exported functions. What is the recommended way to access output?

stephens999 commented 5 years ago

this was an oversight - thanks! I just pushed something that should fix this.

willwerscheid commented 5 years ago

ldf and fitted_values are returned directly -- getter functions aren't really necessary. (fl <- flash(...); fl$fitted_values; fl$ldf). Documentation should be updated.