` profmem::profmem` function hides error message from profiled routine

stephenslab / mashr

An R package for multivariate adaptive shrinkage.

https://stephenslab.github.io/mashr

Other

88 stars 19 forks source link

` profmem::profmem` function hides error message from profiled routine #8

Closed gaow closed 7 years ago

gaow commented 7 years ago

This behavior is inconvenient because it hides error status of the function, causing downstream procedures to fail and display error messages not directly relevant to where it actually fails. If there is no way to show error message and quit properly when profmem is used, then at least we should have a debug switch in the function call, or, I do not mind tying it with some verbosity level.

pcarbo commented 7 years ago

@gaow profmem is only being used for testing; we should remove it once we are happy with the RcppArmadillo implementation.

gaow commented 7 years ago

Made profmem optional anyways with default false, because it has computational overhead.