search

stephenslab / susieR

R package for "sum of single effects" regression.
https://stephenslab.github.io/susieR
Other
174 stars 44 forks source link

Update dimensions for N3finemapping #119

Closed jdblischak closed 3 years ago

jdblischak commented 3 years ago

The fine-mapping vignettes state that the example data has P = 1000. When I saw that there appeared to be 1,001 columns, I first assumed that maybe the first column was the intercept (similar to #118). But as far as I can tell, univariate_regression() automatically adds the intercept term:

https://github.com/stephenslab/susieR/blob/0e48c3c9492b47aa000cbcd450be65c9ca9f9922/R/univariate_regression.R#L68

And when I checked N2finemapping, its dimensions matched those in its documentation.

gaow commented 3 years ago

Thanks @jdblischak i think this is good enough!