search

stephenslab / susieR

R package for "sum of single effects" regression.
https://stephenslab.github.io/susieR
Other
176 stars 45 forks source link

get_objective #55

Closed stephens999 closed 5 years ago

stephens999 commented 5 years ago

i note that this is currently exported. But... it is not properly documented, and further it is not clear if it is useful as the objective does not match the fit.

set.seed(1)
x = matrix(rnorm(100),nrow=10)
y = rnorm(10)
s = susieR::susie(x,y,2,verbose=TRUE)
susieR::susie_get_objective(x,y,s)

yields

[1] "objective:-13.9178013824705"
[1] "objective:-13.9168870676643"
[1] "objective:-13.9153089047561"
[1] "objective:-13.9153086197788"
[1] "objective:-13.9153019958165"
[1] "objective:-13.9153019848613"
> susieR::susie_get_objective(x,y,s)
[1] -14.68734
stephens999 commented 5 years ago

possibly because internally we are using a different x?

gaow commented 5 years ago

Yes at least we center and scale it internally. Any reason to better document and export it? I think verbose is enough for it.

stephens999 commented 5 years ago

well it is already exported. we could stop exporting...

On Thu, Oct 11, 2018 at 10:11 AM gaow notifications@github.com wrote:

Yes at least we center and scale it internally. Any reason to better document and export it? I think verbose is enough for it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/stephenslab/susieR/issues/55#issuecomment-428990090, or mute the thread https://github.com/notifications/unsubscribe-auth/ABt4xc-vXhCAS0WNIMeRUxEWUfNz1ZKkks5uj1-GgaJpZM4XXqoD .