lower case in function names

stephenslab / susieR

R package for "sum of single effects" regression.

https://stephenslab.github.io/susieR

Other

176 stars 45 forks source link

lower case in function names #61

Closed stephens999 closed 5 years ago

stephens999 commented 5 years ago

I think upper case in function names is a pain. i forget which case we need. suggest lower case: susie_get_pip susie_get_cs

stephens999 commented 5 years ago

@gaow is this change going to cause any issues with your ongoing simulations etc?

gaow commented 5 years ago

@stephens999 No it is not a problem. I can always adjust it on my end. I was initially thinking we can keep backwards compatibility but it is more hassles than me simply replacing it in all my applications. Sorry I did not respond to this timely but i'll make sure i close this ticket this week (changes in documentation, vignettes and all my related codes)

gaow commented 5 years ago

Notice that the change will impact any existing projects (hopefully not too many) that uses these functions. Please fix them when you ran into the issue. At this point I do not think we should bother with backwards compatibility yet.