stephenslab / susieR

R package for "sum of single effects" regression.
https://stephenslab.github.io/susieR
Other
176 stars 45 forks source link

Convergence in `trend_filtering` unit test #79

Closed gaow closed 5 years ago

gaow commented 5 years ago

I get warning messages for unit tests of trend filtering code ace32c8e024d10b784fc6c6165234eda6b287992

✔ | 151   2   | test_susie_trendfilter.R [2.5 s]
────────────────────────────────────────────────────────────────────────────────
test_susie_trendfilter.R:22: warning: susie for trend filtering
IBSS algorithm did not converge in 100 iterations!

test_susie_trendfilter.R:22: warning: susie for trend filtering
IBSS algorithm did not converge in 100 iterations!

looks a bit worrisome, but @KaiqianZhang cannot reproduce it on her Macbook or RCC. If I change the random number generator for simulate_tf to generate other data-sets I get from 2 up to 4 warnings -- tried a few seed settings. I'm not digging into it now, but let's use this ticket to track the potential issue.