Closed superbrothers closed 3 years ago
me too,
slug deprecated in Grafana v5.0, https://grafana.com/docs/grafana/latest/http_api/dashboard/
What should we do
I have created a patch to support Grafana 8. This patch may not be compatible with older Grafana, so it will be difficult to merge this in.
/cc #68
So with this change, what should the user interaction expectation be for working with a specific dashboard? Can we no longer have a command that shorthands it out to !graf db my-great-dashboard
instead of !graf db d3adbe3f
?
Reviewing the search API, I don't see a way to guarantee that we always return a single dashboard if we were to try and transform an existing user-friendly URI. It seems like a lot to ask for folks to learn a nine-character, case-sensitive UID to pull up their dashboard.
I see a handful of ways forward:
v3.0.0
that merges @superbrothers's branch with instructions for users of < 8 to remain on the 2.x release/cc @torkelo if you'd like to weigh in.
- Release v3.0.0 that merges @superbrothers branch with instructions for users of < 8 to remain on the 2.x release
I think this is the better way.
Making a note that the test coverage is rather extensive for this package. I started the process of updating it, but it will take a few sessions to get it all done.
In Grafana 8,
GET /dashboards/db/:slug
has been removed. hubot-grafana has used that API endpoint, so it does not work for Grafana 8 :cry:https://github.com/stephenyeargin/hubot-grafana/blob/1f94916ad152a59c74cba4f9d9e894b2f3c28e88/src/grafana.coffee#L185-L187