search

stephenyeargin / hubot-grafana

📈🤖 Query Grafana dashboards
http://docs.grafana.org/tutorials/hubot_howto/
MIT License
154 stars 48 forks source link

Return all matching panels rather than just one #142

Closed stephenyeargin closed 2 years ago

stephenyeargin commented 2 years ago

Fixes #141

stephenyeargin commented 2 years ago

@yohey03518 If you have a moment to test:

    "hubot-grafana": "stephenyeargin/hubot-grafana#bug-141/return-more-than-one-panel",
yohey03518 commented 2 years ago

Hi @stephenyeargin, code was looked good! But sorry I can not find this version stephenyeargin/hubot-grafana#bug-141/return-more-than-one-panel on neither npm nor github npm. It would cause npm install fail with fail reason This is related to npm not being able to find a file. I am not very familiar with npm flow, maybe could provide some more tips for me to test? Thanks again.

stephenyeargin commented 2 years ago

Sure, so it's a feature of NPM (at least as of v8) that you can specify a <github user>/<repository>#<branch> instead of a semantic version to load it directly from GitHub instead of the registry. Looking around the internet, it looks like it may not work in every circumstance.

I'm also comfortable with tagging a version. I'm reasonably sure this is in good shape.

yohey03518 commented 2 years ago

I have verified my build env is using npm 8.1.0 but still get same result. Maybe I need more time to study this new feature. It's good if you can help to tag a version for this. :) Thank you.