search

stephenyeargin / hubot-grafana

📈🤖 Query Grafana dashboards
http://docs.grafana.org/tutorials/hubot_howto/
MIT License
154 stars 48 forks source link

fix: S3 URL parameters in the wrong order causes image to break #155

Closed KeesCBakker closed 1 year ago

KeesCBakker commented 1 year ago

This fixes the problem mentioned in #154.

Think you were going for Virtual-host-style-access as mentioned in the docs: https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-bucket-intro.html#virtual-host-style-url-ex

But the region should come after s3. (and it came before). I've changed the tests accordingly.

stephenyeargin commented 1 year ago

🤦 I must have misread the docs and wrote the tests to cover the wrong URL format.

Context: All of this was done in #152 to ditch Knox as part of an effort to get request removed. That work is still ongoing, as it's made me look at a few other parts of it I want to clean up a bit.

KeesCBakker commented 1 year ago

No worries, awesome effort on the package!