stephenyeargin / hubot-grafana

📈🤖 Query Grafana dashboards
http://docs.grafana.org/tutorials/hubot_howto/
MIT License
154 stars 48 forks source link

Getting rid of the obsolete request dependency #161

Closed KeesCBakker closed 1 year ago

KeesCBakker commented 1 year ago

Is your feature request related to a problem? Please describe. Looks like the request (https://www.npmjs.com/package/request) package is obsolete. I think we can rewrite it to use node-fetch@2 (https://www.npmjs.com/package/node-fetch/v/2.6.12).

Describe the solution you'd like Remove request. Put in fetch.

Describe alternatives you've considered We could do Axios, but that also feels like the wrong dependency. Fetch will become standard in Node.js, according to https://blog.logrocket.com/fetch-api-node-js/

Additional context I'll try to see if it is a drop in replacement.