stephenyeargin / hubot-grafana

📈🤖 Query Grafana dashboards
http://docs.grafana.org/tutorials/hubot_howto/
MIT License
154 stars 48 forks source link

Tests are too slow or timing out #164

Closed KeesCBakker closed 12 months ago

KeesCBakker commented 1 year ago

Is your feature request related to a problem? Please describe. No clue why, but in some cases 1 or 2 tests time out and exceed the given time. The whole test set takes >10s to finish, which makes my VSCode user experience a bit 😭 . Looks like 4 or 5 tests take up most of the time.

Describe the solution you'd like We use some timeouts to respond to async messages. Let's see if we can revisit our testing to make it faster. For another package I used hubot-mock-adapter with some changes: https://keestalkstech.com/2023/08/hubot-testing-revisited/#solving-the-actual-problem-response-testing

Describe alternatives you've considered N/A

Additional context ezgif com-video-to-gif (1)

KeesCBakker commented 1 year ago

When I locally change 1000 to 100 in already greatly improves testing.

KeesCBakker commented 1 year ago

I fear there might be some test interaction. It always works when I run a second time...