Closed KeesCBakker closed 3 months ago
Interesting coverage. We might need to add some extra tests.
"It's not easy being green!" 😁
Will test it on a live Hubot today. Have a great new feature I want to add to our bot, so at the end of the day we'll know.
Did some testing and some further refactoring. All my tests with a live Hubot were also OK.
@stephenyeargin, we can merge if you don't see anything crazy.
Looks good to me, I'll let you do the honors. I see you're sneaking it a bit of TypeScript. 😉
Looks good to me, I'll let you do the honors. I see you're sneaking it a bit of TypeScript. 😉
Hahaha. Yeah the d.ts files work great together with JS Docs.
Partially fixes #177 in which we do a refactor to:
So in this PR we are doing the following:
Adapter
,GrafanaService
and theGrafanaClient
into aBot
class. This makes it a bit easier to interact with the package and not having to build your own class. I could not get the newBot
class to handle all the Hubot requests.--forbid-only --forbid-pending
when doing a commit or push, so we fail when we try to commit amocka.only
.GrafanaService
has all the business rules. One could use them without the bot (to collect multiple dashboards before sending them on).types.d.ts
so JSDoc understands what we're doing.