search

stephenyin / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

libyuv /proc/cpuinfo detect within Chrome sandbox #345

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Neon instruction set is optional and detection is via the file /proc/cpuinfo
This file can not be read within Chrome's sandbox.

r1037 attempts to read the file, but if it can not be read and the NEON code 
has been built in, Neon is assumed to be true.

Find a better way to detect Neon that is sandbox friendly.

Original issue reported on code.google.com by fbarch...@google.com on 22 Jul 2014 at 5:35

GoogleCodeExporter commented 9 years ago 
cross posting from crbug:

This CL provides a way to cache files and makes them available in the sandbox.
https://codereview.chromium.org/416473002/

This CL uses the sandbox file cache from the above CL to provide a weak 
implementation of getauxval, guaranteeing its availability in Chrome.
https://codereview.chromium.org/435533003

Now getauxval can be used inside the Chrome sandbox regardless of glibc 
version. Think that provides everything you need and you will have no 
Chrome-specific code in the libs.

How's this sound to the media guys?
fbarchard@ Could you test this with libyuv et el...you'd need to cherry pick 
the above CLs.

Original comment by fbarch...@chromium.org on 4 Aug 2014 at 9:39

GoogleCodeExporter commented 9 years ago 
Here's example code for using hwcaps

Original comment by fbarch...@google.com on 5 Nov 2014 at 11:26

GoogleCodeExporter commented 9 years ago 
We work around this for ffmpeg by initializing the cpu flags prior to sandbox 
startup, we could do the same for libyuv:

https://code.google.com/p/chromium/codesearch#chromium/src/media/base/media.cc&l
=30

Original comment by dalecurtis@chromium.org on 23 Jul 2015 at 8:13