stateManagement using react context api

stephin007 / Cowin-Vaccine-Availablity-Checker

CoWIN Vaccination Tracker, Below is the PRODUCTION LINK this is updated at end of each day. To see any latest Updates, please check the documentation

https://cowinvaccinetracker.forcommunity.tech/

MIT License

27 stars 19 forks source link

stateManagement using react context api #132

Closed Justinnn07 closed 3 years ago

Justinnn07 commented 3 years ago

🚨 Please review the guidelines for contributing to this repository.

Please check if the PR fulfills these requirements

[x] Make sure you are requesting to NEW-UI. Don't request other protected Branches like staging/master
[x] Make sure no conflicts are present in the code, if so please resolve it(Tip: Always fetch upstream)
[x] Your Commit messages should make sense.
[x] Don't push your package.lock.json as this project uses yarn.lock already.
[x] Check your code additions will fail neither code linting checks nor unit test.

Describe your changes

Bought State management(React context API ) to the app ..
We can now access the req. data on any component!

❤️ Thank you!

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/B9RRXhquuYjG7dMBk6YQT7kLkGnk
✅ Preview: https://cowin-vaccine-git-justinnn07-statemanagement-ste-aec722.vercel.app

Justinnn07 commented 3 years ago

@stephin007 pls review and merge!

stephin007 commented 3 years ago

@Justinnn07 Can you also add the api calls to state? i mean right now we are adding only the states!

stephin007 commented 3 years ago

@Justinnn07 Also Please fill the PR Template!

Justinnn07 commented 3 years ago

@Justinnn07 Can you also add the api calls to state? i mean right now we are adding only the states!

Is it necessary ? I am adding every api response to the reducer

Justinnn07 commented 3 years ago

@Justinnn07 Also Please fill the PR Template!

sure!

stephin007 commented 3 years ago

Is it necessary ? I am adding every api response to the reducer

State management means writing less code right? is this possible what i said?

stephin007 commented 3 years ago

Also, @Justinnn07 are you removing pagination?

Justinnn07 commented 3 years ago

Also, @Justinnn07 are you removing pagination?

Ohk :)

Justinnn07 commented 3 years ago

Also, @Justinnn07 are you removing pagination?

No, I will be using Material-ui Pagination

stephin007 commented 3 years ago

OKay @Justinnn07 it would be better if you raise another PR for pagination changes and use this PR solely for State Management!

please do the necessary

Justinnn07 commented 3 years ago

OKay @Justinnn07 it would be better if you raise another PR for pagination changes and use this PR solely for State Management!

please do the necessary

Sure, will do!