stephin007 / Cowin-Vaccine-Availablity-Checker

CoWIN Vaccination Tracker, Below is the PRODUCTION LINK this is updated at end of each day. To see any latest Updates, please check the documentation
https://cowinvaccinetracker.forcommunity.tech/
MIT License
27 stars 19 forks source link

FilterIssue And Removed Pagination #159

Closed himanshujasuja1040 closed 3 years ago

himanshujasuja1040 commented 3 years ago

🚨 Please review the guidelines for contributing to this repository.

Please check if the PR fulfills these requirements

Describe your changes

❤️ Thank you!

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @stephin007 on Vercel.

@stephin007 first needs to authorize it.

stephin007 commented 3 years ago

~~ @himanshujasuja1040 pagination ia already removed from new-ui ~~

~~What is this PR doing, can you please explain? 🤔😅~~

Never mind saw the changes now!

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/A6S5dbyh2Rc4PwjTm5q1ND3YAiXd
✅ Preview: https://cowin-vaccine-availablity-checker-git-fork-hi-83e353-stephin007.vercel.app

stephin007 commented 3 years ago

@himanshujasuja1040 This filter has major flaw: Steps to reproduce:

So now i should be getting data of covishield which should contain the age group of 18 , i should not see any other data.

stephin007 commented 3 years ago

@himanshujasuja1040 Either you can create a filter which does that kind of filtering or you can give the user option to select only one filter at a time.

in other words: you should create a dropdown which has the filter labels as follows:

  1. Vaccine Type
  2. Age Group
  3. Fare Type

And according to each option you can show other relevant options , say for example if i select vaccine type , i should see another drop just beside the above dropdown which has dropdown option of covishield and covaxin.

So in the UI, User will only see 2 dropdowns!