Closed kunalkumar007 closed 3 years ago
Someone is attempting to deploy a commit to a Personal Account owned by @stephin007 on Vercel.
@stephin007 first needs to authorize it.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/Ck9aL8w3DXmYU4sVxNsfgR2aRaDo
✅ Preview: https://cowin-vaccine-availablity-checker-git-fork-ku-0ad02f-stephin007.vercel.app
@kunlkumar007 Please add the information in the PR template, which is present when you create a PR.
@kunalkumar007 few points:
Also, Can we bring the continents data in a single graph, rather showing all continents in a separate graphs!
The values are of different range and hence they disturb the main concept of charts which is to show information visually and accurately. So, I have divided the data into three charts that are of specific ranges for better visibility and UI Experience.
Yes, I can try it but then it would seem to overlap each other like this one.Tell me about your views on it.
why are there 3 different data sets for "World COVID 19 Information"?
The values are of different range and hence they disturb the main concept of charts which is to show information visually and accurately. So, I have divided the data into three charts that are of specific ranges for better visibility and UI Experience.
Okay understood! but can you use some other charts may be pie chart or doughnut for better UI visibility?
why are there 3 different data sets for "World COVID 19 Information"?
The values are of different range and hence they disturb the main concept of charts which is to show information visually and accurately. So, I have divided the data into three charts that are of specific ranges for better visibility and UI Experience.
Okay understood! but can you use some other charts may be pie chart or doughnut for better UI visibility?
Yes. Please tell me which chart you prefer.
Also, Can we bring the continents data in a single graph, rather than showing all continents in a separate graph!
Yes, I can try it but then it would seem to overlap each other like this one.Tell me about your views on it.
Understood, can we use some other type of Graphical representation for each continent!
as in use a different kind of graph in continent one and a different one the whole world one!
A dough nut chart would do! please can you send me a creenshot as you implement it!
Also, Can we bring the continents data in a single graph, rather than showing all continents in a separate graph!
Yes, I can try it but then it would seem to overlap each other like this one.Tell me about your views on it.
Understood, can we use some other type of Graphical representation for each continent!
as in use a different kind of graph in continent one and a different one the whole world one!
I have to use the doughnut chart or something other and also do I have to make a chart for all continents and one for the whole world?
What you need to do is the following, tell me if anything can't be done.
One add on here which you can add is:
Also, can you please remove these extra white spaces you have added!
Hey @kunalkumar007 can we use different colors for each parameters inside the doughnut chart? right now same colors are being used over agaIn!
Yes, We can have it.
On Sun, Jun 13, 2021 at 11:21 PM Stephin Reji @.***> wrote:
Hey @kunalkumar007 https://github.com/kunalkumar007 can we use different colors for each parameters inside the doughnut chart? right now same colors are being used over agaIn!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stephin007/Cowin-Vaccine-Availablity-Checker/pull/163#issuecomment-860247569, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANFMW2SPLUOZWN6FJEQLFKTTSTVZVANCNFSM46SW7UMA .
@kunalkumar007 i saw your screenshot yesterday, its better we use line graph for the continents and doughnut for the whole world one , just add different colors for the doughnut chart then i guess we are good to go to merge this PR ❤️
@kunalkumar007 also i see alot of indentation issues in your PR, when you save your file it is adding un necessary spaces.
Can you please revert to its original look or may be u can turn off your prettier! this has changed the look - of all the files wherever you have hit save.
Also, can you please remove these extra white spaces you have added!
like this one i mentioned earlier...you can check your commits to see where all there is indentation issues.
@kunalkumar007 everything looks good, just remove the first doughnut chart from the continents one! that's not what i meant in my above comment. But anyways all the work done by you is appreciated 🥇 will merge this request as soon as you remove the doughnut chart as suggested.
Please check if the PR fulfills these requirements
Describe your changes
What kind of change does this PR introduce?
This PR include Chart and ContinentChart component.
What is the current behavior?
No errors, linting errors, and no test failures.
What is the new behavior?
Now, Covid 19 Information shows Line Chart instead of Numbers.
Does this PR introduce a breaking change?
No, breaking changes is there.
💯 Thank you!